]> git.ipfire.org Git - thirdparty/vala.git/commitdiff
gtkmodule: Improve error message for invalid signal element in ui-file
authorYotam Nachum <me@yotam.net>
Sat, 6 Nov 2021 12:33:07 +0000 (14:33 +0200)
committerRico Tzschichholz <ricotz@ubuntu.com>
Sat, 6 Nov 2021 14:29:48 +0000 (15:29 +0100)
codegen/valagtkmodule.vala

index 8b2e88da178314595c1aff809091f860e133970a..01e60535f8959e816a9bfb2c532dbd6037b7dd22 100644 (file)
@@ -187,7 +187,13 @@ public class Vala.GtkModule : GSignalModule {
 
                                if (current_class != null) {
                                        if (signal_name == null || handler_name == null) {
-                                               Report.error (node.source_reference, "Invalid signal in ui file `%s'", ui_file);
+                                               if (signal_name != null) {
+                                                       Report.error (node.source_reference, "Invalid signal `%s' without handler in ui file `%s'", signal_name, ui_file);
+                                               } else if (handler_name != null) {
+                                                       Report.error (node.source_reference, "Invalid signal without name in ui file `%s'", ui_file);
+                                               } else {
+                                                       Report.error (node.source_reference, "Invalid signal without name and handler in ui file `%s'", ui_file);
+                                               }
                                                current_token = reader.read_token (null, null);
                                                continue;
                                        }