]> git.ipfire.org Git - thirdparty/freeswitch.git/commitdiff
FS-11903: Fix errors (again) reported by PVS-Studio Static Code Analyzer for switch_apr.c
authorChris Rienzo <chris@signalwire.com>
Fri, 12 Jul 2019 19:07:21 +0000 (19:07 +0000)
committerAndrey Volk <andywolk@gmail.com>
Mon, 15 Jul 2019 21:32:55 +0000 (01:32 +0400)
src/switch_apr.c

index 8337d0e5a4d3c580575a8aed601cc359ce9a7b6d..25ff8641296b858363df41171f52a03ca07e9619 100644 (file)
@@ -837,27 +837,23 @@ SWITCH_DECLARE(switch_status_t) switch_sockaddr_info_get(switch_sockaddr_t ** sa
 SWITCH_DECLARE(switch_status_t) switch_socket_opt_set(switch_socket_t *sock, int32_t opt, int32_t on)
 {
        if (opt == SWITCH_SO_TCP_KEEPIDLE) {
-               int r = -10;
-
 #if defined(TCP_KEEPIDLE)
+               int r = -10;
                r = setsockopt(sock->socketdes, SOL_TCP, TCP_KEEPIDLE, (void *)&on, sizeof(on));
+               return r ? SWITCH_STATUS_FALSE : SWITCH_STATUS_SUCCESS;
 #else
                return SWITCH_STATUS_NOTIMPL;
 #endif
-
-               return r ? SWITCH_STATUS_FALSE : SWITCH_STATUS_SUCCESS;
        }
 
        if (opt == SWITCH_SO_TCP_KEEPINTVL) {
-               int r = -10;
-
 #if defined(TCP_KEEPINTVL)
+               int r = -10;
                r = setsockopt(sock->socketdes, SOL_TCP, TCP_KEEPINTVL, (void *)&on, sizeof(on));
+               return r ? SWITCH_STATUS_FALSE : SWITCH_STATUS_SUCCESS;
 #else
                return SWITCH_STATUS_NOTIMPL;
 #endif
-
-               return r ? SWITCH_STATUS_FALSE : SWITCH_STATUS_SUCCESS;
        }
 
        return apr_socket_opt_set(sock, opt, on);