[bugfix] Correct min/max TypeScript signatures (#4360)

* Fix #4316: Update TypeScript signatures

* Add min & max typescript tests

* Add overload signatures

diff --git a/moment.d.ts b/moment.d.ts
index 0e749336074b6f66b122e0b2bd17a2c4837d7ce7..a7ce049544384e9cc8a4a08987d29e65a8ae2ffd 100644 (file)
--- a/moment.d.ts
+++ b/moment.d.ts
@@ -684,8 +684,10 @@ declare namespace moment {
   export function weekdaysMin(localeSorted: boolean, format: string): string[];
   export function weekdaysMin(localeSorted: boolean, format: string, index: number): string;
 
-  export function min(...moments: MomentInput[]): Moment;
-  export function max(...moments: MomentInput[]): Moment;
+  export function min(moments: Moment[]): Moment;
+  export function min(...moments: Moment[]): Moment;
+  export function max(moments: Moment[]): Moment;
+  export function max(...moments: Moment[]): Moment;
 
   /**
    * Returns unix time in milliseconds. Overwrite for profit.

diff --git a/typing-tests/moment-tests.ts b/typing-tests/moment-tests.ts
index bafdf117528f2bece7472aba79f376d06f2a7da4..9373c2c7464cb047a76be5becb91defbac6f577b 100644 (file)
--- a/typing-tests/moment-tests.ts
+++ b/typing-tests/moment-tests.ts
@@ -200,6 +200,11 @@ a8.diff(b8, 'days');
 a8.diff(b8, 'years')
 a8.diff(b8, 'years', true);
 
+moment.min([a8, b8]);
+moment.min(a8, b8);
+moment.max([a8, b8]);
+moment.max(a8, b8);
+
 moment([2007, 0, 29]).toDate();
 moment([2007, 1, 23]).toISOString();
 moment(1318874398806).valueOf();