Fix invalid access to disposed memory in main/data unit test

It is not safe to iterate over a macro'd list of ao2 objects, deref them such
that the item's destructor is called, and leave them in the list. The list
macro to iterate over items requires the item to be a valid allocated object
in order to proceed to the next item; with MALLOC_DEBUG on the corruption of
the linked list is caught in the crash.

This patch fixes the invalid access to free'd memory by removing the ao2 item
from the list before de-refing it.

Note that this is a backport of r396915 from Asterisk trunk.
........

Merged revisions 396958 from http://svn.asterisk.org/svn/asterisk/branches/1.8

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/11@396961 65c4cc65-6c06-0410-ace0-fbb531ad65f3

diff --git a/main/data.c b/main/data.c
index 44ba390ad258b7573f7edb0406e912e0d494c2d7..02182ed1bdfc1fabdb9923cf74f3fc59cddaccad 100644 (file)
--- a/main/data.c
+++ b/main/data.c
@@ -1631,7 +1631,7 @@ static void data_filter_destructor(void *obj)
 {
        struct data_filter *filter = obj, *globres;
 
-       AST_LIST_TRAVERSE(&(filter->glob_list), globres, list) {
+       while ((globres = AST_LIST_REMOVE_HEAD(&(filter->glob_list), list))) {
                ao2_ref(globres, -1);
        }