]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
rtc: pcf85063: fix incorrect maximum clock rate handling
authorBrian Masney <bmasney@redhat.com>
Thu, 10 Jul 2025 15:20:24 +0000 (11:20 -0400)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Sun, 3 Aug 2025 00:57:05 +0000 (02:57 +0200)
When pcf85063_clkout_round_rate() is called with a requested rate higher
than the highest supported rate, it currently returns 0, which disables
the clock. According to the clk API, round_rate() should instead return
the highest supported rate. Update the function to return the maximum
supported rate in this case.

Fixes: 8c229ab6048b7 ("rtc: pcf85063: Add pcf85063 clkout control to common clock framework")
Signed-off-by: Brian Masney <bmasney@redhat.com>
Link: https://lore.kernel.org/r/20250710-rtc-clk-round-rate-v1-4-33140bb2278e@redhat.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/rtc/rtc-pcf85063.c

index e3b58cdb1eda729ab26a5a782f63d9d006a879e4..e312bbbf5a426289b7e7197746e4f3a8a6744b2a 100644 (file)
@@ -414,7 +414,7 @@ static long pcf85063_clkout_round_rate(struct clk_hw *hw, unsigned long rate,
                if (clkout_rates[i] <= rate)
                        return clkout_rates[i];
 
-       return 0;
+       return clkout_rates[0];
 }
 
 static int pcf85063_clkout_set_rate(struct clk_hw *hw, unsigned long rate,