s4:dsdb/common: simplify the logic in dsdb_expand_nested_groups()

By using (struct auth_SidAttr) {} we make sure struct auth_SidAttr
can change without leaving uninitialized memory.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jennifer Sutton <jennifersutton@catalyst.net.nz>

diff --git a/source4/dsdb/common/util_groups.c b/source4/dsdb/common/util_groups.c
index 27a87353469734120bd004a5afd882b6ff55ac42..ac476ef9c2252bb12a3a607ebfac3f6f34786b6c 100644 (file)
--- a/source4/dsdb/common/util_groups.c
+++ b/source4/dsdb/common/util_groups.c
@@ -177,8 +177,10 @@ NTSTATUS dsdb_expand_nested_groups(struct ldb_context *sam_ctx,
                        return NT_STATUS_NO_MEMORY;
                }
 
-               (*res_sids)[*num_res_sids].sid = sid;
-               (*res_sids)[*num_res_sids].attrs = sid_attrs;
+               (*res_sids)[*num_res_sids] = (struct auth_SidAttr) {
+                       .sid = sid,
+                       .attrs = sid_attrs,
+               };
 
                ++(*num_res_sids);
        }