]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
wifi: mt76: mt7996: fix uninitialized symbol warning
authorsunliming <sunliming@kylinos.cn>
Sat, 19 Apr 2025 03:15:28 +0000 (11:15 +0800)
committerFelix Fietkau <nbd@nbd.name>
Wed, 21 May 2025 12:49:39 +0000 (14:49 +0200)
Fix below smatch warnings:
drivers/net/wireless/mediatek/mt76/mt7996/main.c:952 mt7996_mac_sta_add_links()
error: uninitialized symbol 'err'.
drivers/net/wireless/mediatek/mt76/mt7996/main.c:1133 mt7996_set_rts_threshold()
error: uninitialized symbol 'ret'.

Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <error27@gmail.com>
Closes: https://lore.kernel.org/r/202504101051.1ya4Z4va-lkp@intel.com/
Signed-off-by: sunliming <sunliming@kylinos.cn>
Link: https://patch.msgid.link/20250419031528.2073892-1-sunliming@linux.dev
Signed-off-by: Felix Fietkau <nbd@nbd.name>
drivers/net/wireless/mediatek/mt76/mt7996/main.c

index 8698c4345af0c867571109c2ff2f3a447d77a579..b77e1721c7b80e328e86abe4a6d15a5283dcdf97 100644 (file)
@@ -991,7 +991,7 @@ mt7996_mac_sta_add_links(struct mt7996_dev *dev, struct ieee80211_vif *vif,
 {
        struct mt7996_sta *msta = (struct mt7996_sta *)sta->drv_priv;
        unsigned int link_id;
-       int err;
+       int err = 0;
 
        for_each_set_bit(link_id, &new_links, IEEE80211_MLD_MAX_NUM_LINKS) {
                struct ieee80211_bss_conf *link_conf;
@@ -1254,7 +1254,7 @@ unlock:
 static int mt7996_set_rts_threshold(struct ieee80211_hw *hw, u32 val)
 {
        struct mt7996_dev *dev = mt7996_hw_dev(hw);
-       int i, ret;
+       int i, ret = 0;
 
        mutex_lock(&dev->mt76.mutex);