]> git.ipfire.org Git - thirdparty/grub.git/commitdiff
tests: Only test MINIX3 volumes of 1 KiB block size
authorGlenn Washburn <development@efficientek.com>
Fri, 17 Sep 2021 23:03:59 +0000 (23:03 +0000)
committerDaniel Kiper <daniel.kiper@oracle.com>
Thu, 14 Oct 2021 13:24:10 +0000 (15:24 +0200)
Apparently there used to be a -B option for mkfs.minix to create a volume
with a specified block size. This version is hard to come by and does not
appear to be available in Debian distributions. So, remove support for
testing a variety of blocks sizes for MINIX3. This allows the MINIX tests
to run because they were being skipped due to not finding a mkfs.minix with
the -B option.

Signed-off-by: Glenn Washburn <development@efficientek.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
tests/minixfs_test.in
tests/util/grub-fs-tester.in

index 3b16a4de09314b95eb45ee21fe9441789b429e51..437d92df641a11aa640b4f7dfc377bd7cba47297 100644 (file)
@@ -25,11 +25,6 @@ if ! mkfs.minix -h | grep -- -3 > /dev/null; then
    exit 77
 fi
 
-if ! mkfs.minix -h | grep -- -B > /dev/null; then
-    echo "mkfs.minix doesn't support variable block size; cannot test minix*fs."
-   exit 77
-fi
-
 "@builddir@/grub-fs-tester" minix
 "@builddir@/grub-fs-tester" minix2
 "@builddir@/grub-fs-tester" minix3
index 0fd2ecf4597439dfc6180fb5e16255f1921f9018..099228c66b475e2591648931cff9cd2e907fcf3b 100644 (file)
@@ -201,7 +201,7 @@ for LOGSECSIZE in $(range "$MINLOGSECSIZE" "$MAXLOGSECSIZE" 1); do
                # OS LIMITATION: Linux rejects non-power-of-two blocks.
                # OS LIMITATION: Linux rejects > 4096.
            MINBLKSIZE=1024
-           MAXBLKSIZE=4096;;
+           MAXBLKSIZE=1024;;
     esac
     if test "$BLKSTEP" -eq 0; then
        blksizes="$(powrange "$MINBLKSIZE" "$MAXBLKSIZE")"
@@ -697,7 +697,7 @@ for LOGSECSIZE in $(range "$MINLOGSECSIZE" "$MAXLOGSECSIZE" 1); do
                    "mkfs.minix" -v "${MOUNTDEVICE}"
                    MOUNTFS="minix";;
                x"minix3")
-                   "mkfs.minix" -B $BLKSIZE -3 "${MOUNTDEVICE}"
+                   "mkfs.minix" -3 "${MOUNTDEVICE}"
                    MOUNTFS="minix";;
                x"ntfs"*)
                    "mkfs.ntfs" -s "$SECSIZE" -c "$BLKSIZE" -L "$FSLABEL" -Q -q "${MOUNTDEVICE}"