]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
net: phy: realtek: add interrupt support for RTL8221B
authorJianhui Zhao <zhaojh329@gmail.com>
Sun, 2 Nov 2025 15:26:37 +0000 (16:26 +0100)
committerJakub Kicinski <kuba@kernel.org>
Tue, 4 Nov 2025 00:45:46 +0000 (16:45 -0800)
This commit introduces interrupt support for RTL8221B (C45 mode).
Interrupts are mapped on the VEND2 page. VEND2 registers are only
accessible via C45 reads and cannot be accessed by C45 over C22.

Signed-off-by: Jianhui Zhao <zhaojh329@gmail.com>
[Enable only link state change interrupts]
Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/20251102152644.1676482-1-olek2@wp.pl
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/phy/realtek/realtek_main.c

index 1fd4b6cf5c1e18fbd2f3f96283d167c626a8e2e9..417f9a88aab66f9074f5a6c18615378d695066e3 100644 (file)
  */
 #define RTL822X_VND2_C22_REG(reg)              (0xa400 + 2 * (reg))
 
+#define RTL8221B_VND2_INER                     0xa4d2
+#define RTL8221B_VND2_INER_LINK_STATUS         BIT(4)
+
+#define RTL8221B_VND2_INSR                     0xa4d4
+
 #define RTL8224_MII_RTCT                       0x11
 #define RTL8224_MII_RTCT_ENABLE                        BIT(0)
 #define RTL8224_MII_RTCT_PAIR_A                        BIT(4)
@@ -1880,6 +1885,53 @@ static irqreturn_t rtl9000a_handle_interrupt(struct phy_device *phydev)
        return IRQ_HANDLED;
 }
 
+static int rtl8221b_ack_interrupt(struct phy_device *phydev)
+{
+       int err;
+
+       err = phy_read_mmd(phydev, MDIO_MMD_VEND2, RTL8221B_VND2_INSR);
+
+       return (err < 0) ? err : 0;
+}
+
+static int rtl8221b_config_intr(struct phy_device *phydev)
+{
+       int err;
+
+       if (phydev->interrupts == PHY_INTERRUPT_ENABLED) {
+               err = rtl8221b_ack_interrupt(phydev);
+               if (err)
+                       return err;
+
+               err = phy_write_mmd(phydev, MDIO_MMD_VEND2, RTL8221B_VND2_INER,
+                                   RTL8221B_VND2_INER_LINK_STATUS);
+       } else {
+               err = phy_write_mmd(phydev, MDIO_MMD_VEND2,
+                                   RTL8221B_VND2_INER, 0);
+               if (err)
+                       return err;
+
+               err = rtl8221b_ack_interrupt(phydev);
+       }
+
+       return err;
+}
+
+static irqreturn_t rtl8221b_handle_interrupt(struct phy_device *phydev)
+{
+       int err;
+
+       err = rtl8221b_ack_interrupt(phydev);
+       if (err) {
+               phy_error(phydev);
+               return IRQ_NONE;
+       }
+
+       phy_trigger_machine(phydev);
+
+       return IRQ_HANDLED;
+}
+
 static struct phy_driver realtek_drvs[] = {
        {
                PHY_ID_MATCH_EXACT(0x00008201),
@@ -2054,6 +2106,8 @@ static struct phy_driver realtek_drvs[] = {
        }, {
                .match_phy_device = rtl8221b_vb_cg_c45_match_phy_device,
                .name           = "RTL8221B-VB-CG 2.5Gbps PHY (C45)",
+               .config_intr    = rtl8221b_config_intr,
+               .handle_interrupt = rtl8221b_handle_interrupt,
                .probe          = rtl822x_probe,
                .config_init    = rtl822xb_config_init,
                .get_rate_matching = rtl822xb_get_rate_matching,
@@ -2078,6 +2132,8 @@ static struct phy_driver realtek_drvs[] = {
        }, {
                .match_phy_device = rtl8221b_vm_cg_c45_match_phy_device,
                .name           = "RTL8221B-VM-CG 2.5Gbps PHY (C45)",
+               .config_intr    = rtl8221b_config_intr,
+               .handle_interrupt = rtl8221b_handle_interrupt,
                .probe          = rtl822x_probe,
                .config_init    = rtl822xb_config_init,
                .get_rate_matching = rtl822xb_get_rate_matching,