]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
Fix a memory leak in the node_device_udev code
authorChris Lalancette <clalance@redhat.com>
Wed, 28 Apr 2010 19:49:10 +0000 (15:49 -0400)
committerChris Lalancette <clalance@redhat.com>
Thu, 29 Apr 2010 13:15:54 +0000 (09:15 -0400)
We were over-writing a pointer without freeing it in
case of a disk device, leading to a memory leak.

Signed-off-by: Chris Lalancette <clalance@redhat.com>
src/node_device/node_device_udev.c

index 3a5a7e2e44b6d18b9887aa68f99c1956c8fbd9ae..bcfe991fb796d7382e1110ec1a7a4f4c09e93ad4 100644 (file)
@@ -815,13 +815,6 @@ static int udevProcessDisk(struct udev_device *device,
     union _virNodeDevCapData *data = &def->caps->data;
     int ret = 0;
 
-    data->storage.drive_type = strdup("disk");
-    if (data->storage.drive_type == NULL) {
-        virReportOOMError();
-        ret = -1;
-        goto out;
-    }
-
     if (udevGetUint64SysfsAttr(device,
                                "size",
                                &data->storage.num_blocks) == PROPERTY_ERROR) {