]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
rtc: amlogic-a4: Remove IRQF_ONESHOT
authorSebastian Andrzej Siewior <bigeasy@linutronix.de>
Wed, 28 Jan 2026 09:55:32 +0000 (10:55 +0100)
committerThomas Gleixner <tglx@kernel.org>
Sun, 1 Feb 2026 16:37:16 +0000 (17:37 +0100)
Passing IRQF_ONESHOT ensures that the interrupt source is masked until
the secondary (threaded) handler is done. If only a primary handler is
used then the flag makes no sense because the interrupt can not fire
(again) while its handler is running.

The flag also prevents force-threading of the primary handler and the
irq-core will warn about this.

Remove IRQF_ONESHOT from irqflags.

Fixes: c89ac9182ee29 ("rtc: support for the Amlogic on-chip RTC")
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Thomas Gleixner <tglx@kernel.org>
Reviewed-by: Xianwei Zhao <xianwei.zhao@amlogic.com>
Link: https://patch.msgid.link/20260128095540.863589-13-bigeasy@linutronix.de
drivers/rtc/rtc-amlogic-a4.c

index 123fb372fc9fe042a1efb3348edd052764ffdbff..50938c35af36a6efe782b51ab39f689758a64916 100644 (file)
@@ -369,7 +369,7 @@ static int aml_rtc_probe(struct platform_device *pdev)
                return PTR_ERR(rtc->rtc_dev);
 
        ret = devm_request_irq(dev, rtc->irq, aml_rtc_handler,
-                              IRQF_ONESHOT, "aml-rtc alarm", rtc);
+                              0, "aml-rtc alarm", rtc);
        if (ret) {
                dev_err_probe(dev, ret, "IRQ%d request failed, ret = %d\n",
                              rtc->irq, ret);