Better placement for Dropdown + Handle flip of Tooltip/Popover

diff --git a/js/src/dropdown.js b/js/src/dropdown.js
index d678a3a0289a7eeb59dbb3367c037d67e8988190..613a2381283618e08568a376927ce7aaff443141 100644 (file)
--- a/js/src/dropdown.js
+++ b/js/src/dropdown.js
@@ -65,8 +65,8 @@ const Dropdown = (($) => {
   }
 
   const AttachmentMap = {
-    TOP    : 'top',
-    BOTTOM : 'bottom'
+    TOP    : 'top-start',
+    BOTTOM : 'bottom-start'
   }
 
   const Default = {

diff --git a/js/src/tooltip.js b/js/src/tooltip.js
index 2c34ac5d7cbcf0f5c52ccb9dcff81a954c6ada52..b446d9bcc69da26de71f139d45af1762e9c02bd1 100644 (file)
--- a/js/src/tooltip.js
+++ b/js/src/tooltip.js
@@ -287,6 +287,12 @@ const Tooltip = (($) => {
             offset : {
               offset : this.config.offset
             }
+          },
+          onCreate : (data) => {
+            this._handlePopperPlacementChange(data)
+          },
+          onUpdate : (data) => {
+            this._handlePopperPlacementChange(data)
           }
         })
 
@@ -637,6 +643,12 @@ const Tooltip = (($) => {
       }
     }
 
+    _handlePopperPlacementChange(data) {
+      if (data.originalPlacement !== data.placement) {
+        this._cleanTipClass()
+        this.addAttachmentClass(this._getAttachment(data.placement))
+      }
+    }
 
     // static
 

diff --git a/js/tests/visual/popover.html b/js/tests/visual/popover.html
index 4fd813c0603f4aab8716e98c3deeec1edf71bc4c..93fa01f9da9eafbb76dd00067a566c557f6b4e5d 100644 (file)
--- a/js/tests/visual/popover.html
+++ b/js/tests/visual/popover.html
@@ -10,7 +10,7 @@
     <div class="container">
       <h1>Popover <small>Bootstrap Visual Test</small></h1>
 
-      <button type="button" class="btn btn-secondary" data-container="body" data-toggle="popover" data-placement="top" data-content="Vivamus sagittis lacus vel augue laoreet rutrum faucibus.">
+      <button type="button" class="btn btn-secondary" data-container="body" data-toggle="popover" data-placement="top" data-content="Default placement was on top but not enough place">
         Popover on top
       </button>