]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
xenParseXMDisk: Use automatic memory clearing and remove 'ret' variable
authorPeter Krempa <pkrempa@redhat.com>
Tue, 3 Aug 2021 13:08:54 +0000 (15:08 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Fri, 6 Aug 2021 06:53:26 +0000 (08:53 +0200)
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
src/libxl/xen_xm.c

index ac86ddf9b7c29c09e9d019bfba2eb7ec0531712e..f978b94f9339088b255bba202e3576897d3bf358 100644 (file)
@@ -238,9 +238,9 @@ xenParseXMDisk(char *entry, int hvm)
 static int
 xenParseXMDiskList(virConf *conf, virDomainDef *def)
 {
-    char **disks = NULL, **entries;
+    g_auto(GStrv) disks = NULL;
+    GStrv entries;
     int hvm = def->os.type == VIR_DOMAIN_OSTYPE_HVM;
-    int ret = -1;
     int rc;
 
     rc = virConfGetValueStringList(conf, "disk", false, &disks);
@@ -258,10 +258,7 @@ xenParseXMDiskList(virConf *conf, virDomainDef *def)
         VIR_APPEND_ELEMENT(def->disks, def->ndisks, disk);
     }
 
-    ret = 0;
-
-    g_strfreev(disks);
-    return ret;
+    return 0;
 }