]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
pinctrl: meson: use new GPIO line value setter callbacks
authorBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Tue, 8 Apr 2025 07:17:42 +0000 (09:17 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Tue, 15 Apr 2025 21:48:10 +0000 (23:48 +0200)
struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://lore.kernel.org/20250408-gpiochip-set-rv-pinctrl-part1-v1-5-c9d521d7c8c7@linaro.org
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/meson/pinctrl-meson.c

index 253a0cc57e396dd9eb12fbc37bd6cf56801b5dc8..e7485c82089ca671cee82f3119fb934eb7dabfa8 100644 (file)
@@ -580,9 +580,9 @@ static int meson_gpio_direction_output(struct gpio_chip *chip, unsigned gpio,
                                              gpio, value);
 }
 
-static void meson_gpio_set(struct gpio_chip *chip, unsigned gpio, int value)
+static int meson_gpio_set(struct gpio_chip *chip, unsigned int gpio, int value)
 {
-       meson_pinconf_set_drive(gpiochip_get_data(chip), gpio, value);
+       return meson_pinconf_set_drive(gpiochip_get_data(chip), gpio, value);
 }
 
 static int meson_gpio_get(struct gpio_chip *chip, unsigned gpio)
@@ -616,7 +616,7 @@ static int meson_gpiolib_register(struct meson_pinctrl *pc)
        pc->chip.direction_input = meson_gpio_direction_input;
        pc->chip.direction_output = meson_gpio_direction_output;
        pc->chip.get = meson_gpio_get;
-       pc->chip.set = meson_gpio_set;
+       pc->chip.set_rv = meson_gpio_set;
        pc->chip.base = -1;
        pc->chip.ngpio = pc->data->num_pins;
        pc->chip.can_sleep = false;