Fix KDC memory leak on failed S4U2Proxy requests

Make sure to release stkt_server in process_tgs_req() if we fail
before its disposition is determined.  Reported by Will Fiveash.

ticket: 8363
target_version: 1.14-next
target_version: 1.13-next
tags: pullup

diff --git a/src/kdc/do_tgs_req.c b/src/kdc/do_tgs_req.c
index a52c960478021f53c44959764f2b4f50f3688425..547a41441767bdb9a8d2360e9f26827c632fa779 100644 (file)
--- a/src/kdc/do_tgs_req.c
+++ b/src/kdc/do_tgs_req.c
@@ -869,6 +869,7 @@ cleanup:
     if (state)
         kdc_free_rstate(state);
     krb5_db_free_principal(kdc_context, server);
+    krb5_db_free_principal(kdc_context, stkt_server);
     krb5_db_free_principal(kdc_context, header_server);
     krb5_db_free_principal(kdc_context, client);
     krb5_db_free_principal(kdc_context, local_tgt_storage);