]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
bhyve: Don't stack-allocate huge error buffers
authorPeter Krempa <pkrempa@redhat.com>
Tue, 20 Sep 2022 09:16:27 +0000 (11:16 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Mon, 4 Sep 2023 08:31:52 +0000 (10:31 +0200)
_POSIX2_LINE_MAX is 2048. Allocate the buffers on the heap instead.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Kristina Hanicova <khanicov@redhat.com>
src/bhyve/bhyve_process.c

index 80d5a8804fddd908b0f800d5dde2e869bf5c1cfd..c8e1a10afe4b846442e02a75b6aa4130ff2908f7 100644 (file)
@@ -380,7 +380,7 @@ virBhyveGetDomainTotalCpuStats(virDomainObj *vm,
 {
     struct kinfo_proc *kp;
     kvm_t *kd;
-    char errbuf[_POSIX2_LINE_MAX];
+    g_autofree char *errbuf = g_new0(char, _POSIX2_LINE_MAX);
     int nprocs;
     int ret = -1;
 
@@ -481,7 +481,7 @@ virBhyveProcessReconnectAll(struct _bhyveConn *driver)
 {
     kvm_t *kd;
     struct bhyveProcessReconnectData data;
-    char errbuf[_POSIX2_LINE_MAX];
+    g_autofree char *errbuf = g_new0(char, _POSIX2_LINE_MAX);
 
     if ((kd = kvm_openfiles(NULL, NULL, NULL, O_RDONLY, errbuf)) == NULL) {
         virReportError(VIR_ERR_SYSTEM_ERROR,