syntax-check: fix violations and re-enable sc_error_message_uppercase.

* cfg.mk (local-checks-to-fix): Remove
sc_error_message_uppercase from list of disabled checks.
(exclude_file_name_regexp--sc_error_message_uppercase): Don't
match cvsu, which is not our file to edit.
* doc/libtool.texi: Use lowercase error message in example.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>

diff --git a/bootstrap b/bootstrap
index dd757ae082b1426a3500a5754fc600e87ca7c253..8776e219d9b8a657163f13f0a9f228016b6ebc9b 100755 (executable)
--- a/bootstrap
+++ b/bootstrap
@@ -1934,7 +1934,8 @@ $func_strrow_result
 # Echo program name prefixed message to standard error, and exit.
 func_internal_error ()
 {
-    func_fatal_error "INTERNAL: " ${1+"$@"} "
+    func_fatal_error "\
+INTERNAL: " ${1+"$@"} "
           Please report this bug to \`bug-gnulib@gnu.org'
           in as much detail as possible."
 }

diff --git a/cfg.mk b/cfg.mk
index c39cc51b5a8c2cc388ea7c374a8f078c95644ce5..4c50f548d3de17a17ab14e423b6e9c0c42d67338 100644 (file)
--- a/cfg.mk
+++ b/cfg.mk
@@ -64,7 +64,6 @@ local-checks-to-skip =                                \
        sc_GPL_version                          \
        sc_bindtextdomain                       \
        sc_cast_of_x_alloc_return_value         \
-       sc_error_message_uppercase              \
        sc_program_name                         \
        sc_unmarked_diagnostics
 
@@ -72,6 +71,9 @@ local-checks-to-skip =                                \
 # bindtextdomain: libtool isn't internationalized
 # cast_of_x_alloc_return_value:
 #         We support C++ compilation which does require casting here.
-# error_message_uppercase: we like our error messages
 # program_name: libtool has no programs!
 # unmarked_diagnostics: libtool isn't internationalized
+
+# List syntax-check exempted files.
+exclude_file_name_regexp--sc_error_message_uppercase = \
+  ^$(_build-aux)/cvsu$$

diff --git a/doc/libtool.texi b/doc/libtool.texi
index 20292ab41b99b671056a11c6cf932757aecb61d2..d96e66d3126cde7552755262d4e3f9cd6835321a 100644 (file)
--- a/doc/libtool.texi
+++ b/doc/libtool.texi
@@ -4635,7 +4635,7 @@ This function allows you to integrate your own error messages into
 If the allocation of an identifier fails, this function returns -1.
 
 @example
-int myerror = lt_dladderror ("Doh!");
+int myerror = lt_dladderror ("doh!");
 if (myerror < 0)
   perror (lt_dlerror ());
 @end example