]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
scsi: csiostor: Fix dereference of null pointer rn
authorColin Ian King <colin.i.king@gmail.com>
Thu, 29 Jan 2026 15:53:32 +0000 (15:53 +0000)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 4 Feb 2026 03:33:32 +0000 (22:33 -0500)
The error exit path when rn is NULL ends up deferencing the null pointer rn
via the use of the macro CSIO_INC_STATS. Fix this by adding a new error
return path label after the use of the macro to avoid the deference.

Fixes: a3667aaed569 ("[SCSI] csiostor: Chelsio FCoE offload driver")
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Link: https://patch.msgid.link/20260129155332.196338-1-colin.i.king@gmail.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/csiostor/csio_scsi.c

index c29bf2807e310406aa9e2c9fcec4b1511047a6b9..05137784f369b1edcf83027935b87e8b16e3aa47 100644 (file)
@@ -2074,7 +2074,7 @@ csio_eh_lun_reset_handler(struct scsi_cmnd *cmnd)
        struct csio_scsi_level_data sld;
 
        if (!rn)
-               goto fail;
+               goto fail_ret;
 
        csio_dbg(hw, "Request to reset LUN:%llu (ssni:0x%x tgtid:%d)\n",
                      cmnd->device->lun, rn->flowid, rn->scsi_id);
@@ -2220,6 +2220,7 @@ fail_ret_ioreq:
        csio_put_scsi_ioreq_lock(hw, scsim, ioreq);
 fail:
        CSIO_INC_STATS(rn, n_lun_rst_fail);
+fail_ret:
        return FAILED;
 }