Ssl::CertValidationHelper::sslSubmit: Assure that the callback->getDialer()

 ... return non NULL before use the result

Detected by Coverity Scan. Issue 1346998

diff --git a/src/ssl/helper.cc b/src/ssl/helper.cc
index 939c4d13b4ec5700c237349f016d11887bc7803c..c378758ea4e07c116a4093aedb14a8f169c12870 100644 (file)
--- a/src/ssl/helper.cc
+++ b/src/ssl/helper.cc
@@ -264,6 +264,7 @@ void Ssl::CertValidationHelper::sslSubmit(Ssl::CertValidationRequest const &requ
         Ssl::CertValidationResponse::Pointer resp = new Ssl::CertValidationResponse;
         resp->resultCode = ::Helper::BrokenHelper;
         Ssl::CertValidationHelper::CbDialer *dialer = dynamic_cast<Ssl::CertValidationHelper::CbDialer*>(callback->getDialer());
+        Must(dialer);
         dialer->arg1 = resp;
         ScheduleCallHere(callback);
         return;
@@ -287,6 +288,7 @@ void Ssl::CertValidationHelper::sslSubmit(Ssl::CertValidationRequest const &requ
             (validationResponse = CertValidationHelper::HelperCache->get(crtdvdData->query.c_str()))) {
 
         CertValidationHelper::CbDialer *dialer = dynamic_cast<CertValidationHelper::CbDialer*>(callback->getDialer());
+        Must(dialer);
         dialer->arg1 = *validationResponse;
         ScheduleCallHere(callback);
         SSL_free(crtdvdData->ssl);