]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
bpo-35518: Skip test that relies on a deceased network service. (GH-15349)
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Wed, 21 Aug 2019 04:12:18 +0000 (21:12 -0700)
committerGitHub <noreply@github.com>
Wed, 21 Aug 2019 04:12:18 +0000 (21:12 -0700)
If this service had thoroughly vanished, we could just ignore the
test until someone gets around to either recreating such a service
or redesigning the test to somehow work locally.  The
`support.transient_internet` mechanism catches the failure to
resolve the domain name, and skips the test.

But in fact the domain snakebite.net does still exist, as do its
nameservers -- and they can be quite slow to reply.  As a result
this test can easily take 20-30s before it gets auto-skipped.

So, skip the test explicitly up front.
(cherry picked from commit 5b95a1507e349da5adae6d2ab57deac3bdd12f15)

Co-authored-by: Greg Price <gnprice@gmail.com>
Lib/test/test_timeout.py

index bb9252d1a43341aead84841ad0e88cd49f34cb5a..51690335b70e887ea7dd817be6ff2bca917ddc1c 100644 (file)
@@ -106,6 +106,7 @@ class TimeoutTestCase(unittest.TestCase):
     def tearDown(self):
         self.sock.close()
 
+    @unittest.skipIf(True, 'need to replace these hosts; see bpo-35518')
     def testConnectTimeout(self):
         # Choose a private address that is unlikely to exist to prevent
         # failures due to the connect succeeding before the timeout.