]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ALSA: 6fire: Use safer strscpy() instead of strcpy()
authorTakashi Iwai <tiwai@suse.de>
Thu, 10 Jul 2025 10:07:17 +0000 (12:07 +0200)
committerTakashi Iwai <tiwai@suse.de>
Fri, 11 Jul 2025 07:53:35 +0000 (09:53 +0200)
Use a safer function strscpy() instead of strcpy() for copying to
arrays.

Only idiomatic code replacement, and no functional changes.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Link: https://patch.msgid.link/20250710100727.22653-96-tiwai@suse.de
sound/usb/6fire/chip.c
sound/usb/6fire/midi.c
sound/usb/6fire/pcm.c

index d562a30b087f0107a640285c30b1998570b62ef6..9eb4bf9b138b728dd1947620d6d2bf74d42893cb 100644 (file)
@@ -125,8 +125,8 @@ static int usb6fire_chip_probe(struct usb_interface *intf,
                dev_err(&intf->dev, "cannot create alsa card.\n");
                return ret;
        }
-       strcpy(card->driver, "6FireUSB");
-       strcpy(card->shortname, "TerraTec DMX6FireUSB");
+       strscpy(card->driver, "6FireUSB");
+       strscpy(card->shortname, "TerraTec DMX6FireUSB");
        sprintf(card->longname, "%s at %d:%d", card->shortname,
                        device->bus->busnum, device->devnum);
 
index de2691d58de6ef04a84c4ae302527fd09df7a1b2..923f7767e62fc7e7830ba2192a5891715d531990 100644 (file)
@@ -183,7 +183,7 @@ int usb6fire_midi_init(struct sfire_chip *chip)
                return ret;
        }
        rt->instance->private_data = rt;
-       strcpy(rt->instance->name, "DMX6FireUSB MIDI");
+       strscpy(rt->instance->name, "DMX6FireUSB MIDI");
        rt->instance->info_flags = SNDRV_RAWMIDI_INFO_OUTPUT |
                        SNDRV_RAWMIDI_INFO_INPUT |
                        SNDRV_RAWMIDI_INFO_DUPLEX;
index 32c39d8bd2e5532aa46a28cb02a71d97bf33b05c..d53cad97889afb382a63bbb3da1264ef709375c3 100644 (file)
@@ -640,7 +640,7 @@ int usb6fire_pcm_init(struct sfire_chip *chip)
        }
 
        pcm->private_data = rt;
-       strcpy(pcm->name, "DMX 6Fire USB");
+       strscpy(pcm->name, "DMX 6Fire USB");
        snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_PLAYBACK, &pcm_ops);
        snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_CAPTURE, &pcm_ops);
        snd_pcm_set_managed_buffer_all(pcm, SNDRV_DMA_TYPE_VMALLOC, NULL, 0, 0);