]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
schemas: rng: Make secret optional in storage vol
authorHan Han <hhan@redhat.com>
Wed, 6 Jul 2022 02:42:02 +0000 (10:42 +0800)
committerMichal Privoznik <mprivozn@redhat.com>
Thu, 7 Jul 2022 10:18:17 +0000 (12:18 +0200)
For a qcow2 storage volume with luks encryption created by qemu-img, its
dumped storage vol XML has no secret element in encryption:
<volume type='file'>
    ...
    <encryption format='luks'>
    </encryption>
    ...
</volume>

That will cause a failure in rng validation. Fix that validation failure.

Signed-off-by: Han Han <hhan@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
src/conf/schemas/storagecommon.rng

index 10f1bc6a15be49f9402da4f65608b79a88ca6c0a..76714c9aadabaf554c1f6d6adee23b129be136e3 100644 (file)
           </choice>
         </attribute>
       </optional>
-      <interleave>
-        <ref name="secret"/>
-        <optional>
-          <element name="cipher">
-            <ref name="keycipher"/>
-          </element>
-          <element name="ivgen">
-            <ref name="keyivgen"/>
-          </element>
-        </optional>
-      </interleave>
+      <optional>
+        <interleave>
+          <ref name="secret"/>
+          <optional>
+            <element name="cipher">
+              <ref name="keycipher"/>
+            </element>
+            <element name="ivgen">
+              <ref name="keyivgen"/>
+            </element>
+          </optional>
+        </interleave>
+      </optional>
     </element>
   </define>