set `reload_status` to fail before logging it

The `reload_status` is set to `NAMED_RELOAD_FAILED` after the log line is
printed about this change. Update `reload_status` first, to avoid
(unlikely) case where a test waiting for this log line would attempt a
RNDC reload query but it would be processed by `named` before the status
is updated.

diff --git a/bin/named/server.c b/bin/named/server.c
index 34abfc7fc61cfafbac064300aff55e1c97ac83ee..4392760da1708783f0fc2a92d1b5886bbb8804d5 100644 (file)
--- a/bin/named/server.c
+++ b/bin/named/server.c
@@ -9861,11 +9861,11 @@ loadconfig(named_server_t *server) {
                              ISC_LOG_INFO,
                              "reloading configuration succeeded");
        } else {
+               atomic_store(&server->reload_status, NAMED_RELOAD_FAILED);
                isc_log_write(NAMED_LOGCATEGORY_GENERAL, NAMED_LOGMODULE_SERVER,
                              ISC_LOG_ERROR,
                              "reloading configuration failed: %s",
                              isc_result_totext(result));
-               atomic_store(&server->reload_status, NAMED_RELOAD_FAILED);
        }
 
        return result;