]> git.ipfire.org Git - thirdparty/hostap.git/commitdiff
Fix GKeyDoneStations tracking for VLAN
authorJouni Malinen <quic_jouni@quicinc.com>
Tue, 13 Aug 2024 09:55:16 +0000 (12:55 +0300)
committerJouni Malinen <j@w1.fi>
Tue, 13 Aug 2024 09:58:45 +0000 (12:58 +0300)
The AP MLD change to use a helper function for this broke the design
that depends on the value for sm->group (i.e., the currently assigned
VLAN) being used instead of the sm->wpa_auth->group. Restore previous
behavior to fix GKeyDoneStations tracking when VLANs are used.

Fixes: 78adbf2c08f4 ("AP MLD: Mark GKeyDone completed for STAs in a helper function")
Signed-off-by: Jouni Malinen <quic_jouni@quicinc.com>
src/ap/wpa_auth.c

index 93f157d62c1221e28d2ed8c9055cc140f2c76957..a34563ce444b39f8944e33c64c56bedba3cc5cdc 100644 (file)
@@ -112,10 +112,7 @@ static void wpa_gkeydone_sta(struct wpa_state_machine *sm)
        int link_id;
 #endif /* CONFIG_IEEE80211BE */
 
-       if (!sm->wpa_auth)
-               return;
-
-       sm->wpa_auth->group->GKeyDoneStations--;
+       sm->group->GKeyDoneStations--;
        sm->GUpdateStationKeys = false;
 
 #ifdef CONFIG_IEEE80211BE