]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
thermal/debugfs: Create records for cdev states as they get used
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Thu, 25 Apr 2024 12:24:10 +0000 (14:24 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 30 May 2024 07:49:16 +0000 (09:49 +0200)
[ Upstream commit f4ae18fcb652c6cccc834ded525ac37f91d5cdb1 ]

Because thermal_debug_cdev_state_update() only creates a duration record
for the old state of a cooling device, if its new state is used for the
first time, there will be no record for it and cdev_dt_seq_show() will
not print the duration information for it even though it contains code
to compute the duration value in that case.

Address this by making thermal_debug_cdev_state_update() create a
duration record for the new state if there is none.

Fixes: 755113d76786 ("thermal/debugfs: Add thermal cooling device debugfs information")
Reported-by: Lukasz Luba <lukasz.luba@arm.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
Tested-by: Lukasz Luba <lukasz.luba@arm.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/thermal/thermal_debugfs.c

index 47ab95b3699e9706a5869298eb9bffea7893fde2..2891d2ab4875c4ee66aaf34fc415d55d8865405b 100644 (file)
@@ -435,6 +435,14 @@ void thermal_debug_cdev_state_update(const struct thermal_cooling_device *cdev,
        }
 
        cdev_dbg->current_state = new_state;
+
+       /*
+        * Create a record for the new state if it is not there, so its
+        * duration will be printed by cdev_dt_seq_show() as expected if it
+        * runs before the next state transition.
+        */
+       thermal_debugfs_cdev_record_get(thermal_dbg, cdev_dbg->durations, new_state);
+
        transition = (old_state << 16) | new_state;
 
        /*