Tidy up cleanup path in check_signer()

The cloned signature rdataset was not disassociated on the early
return taken when dns_dnssec_keyfromrdata() fails to parse the DNSKEY
public-key data.  In every current caller val->sigrdataset reaches
check_signer() rdatalist-backed, so dns_rdataset_clone() copies the
struct without taking any reference and dns_rdataset_disassociate()
is a no-op -- no memory is actually leaked today.  Hoist the key
parse out of the per-RRSIG loop and let the function fall through
to a single cleanup path, so the parse and the iteration cannot
diverge again.

Assisted-by: Claude:claude-opus-4-7

diff --git a/lib/dns/validator.c b/lib/dns/validator.c
index f770a9cc7083db3506e1f7bcbc037ad3a7fad853..b3c0a52a29806d73aeaaeeb2c6b971b112472466 100644 (file)
--- a/lib/dns/validator.c
+++ b/lib/dns/validator.c
@@ -1970,6 +1970,13 @@ check_signer(dns_validator_t *val, dns_rdata_t *keyrdata, uint16_t keyid,
        dst_key_t *dstkey = NULL;
        isc_result_t result;
        dns_rdataset_t rdataset = DNS_RDATASET_INIT;
+
+       result = dns_dnssec_keyfromrdata(val->name, keyrdata, val->view->mctx,
+                                        &dstkey);
+       if (result != ISC_R_SUCCESS) {
+               return result;
+       }
+
        dns_rdataset_clone(val->sigrdataset, &rdataset);
 
        for (result = dns_rdataset_first(&rdataset); result == ISC_R_SUCCESS;
@@ -1983,22 +1990,14 @@ check_signer(dns_validator_t *val, dns_rdata_t *keyrdata, uint16_t keyid,
                if (keyid != sig.keyid || algorithm != sig.algorithm) {
                        continue;
                }
-               if (dstkey == NULL) {
-                       result = dns_dnssec_keyfromrdata(
-                               val->name, keyrdata, val->view->mctx, &dstkey);
-                       if (result != ISC_R_SUCCESS) {
-                               return result;
-                       }
-               }
+
                result = verify(val, dstkey, &rdata, sig.keyid);
                if (result == ISC_R_SUCCESS || result == ISC_R_QUOTA) {
                        break;
                }
        }
 
-       if (dstkey != NULL) {
-               dst_key_free(&dstkey);
-       }
+       dst_key_free(&dstkey);
        dns_rdataset_disassociate(&rdataset);
 
        return result;