]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
smbtorture: adjust "base.delaywrite.finfo update on close" for modern SMB delayed...
authorRalph Boehme <slow@samba.org>
Mon, 3 Mar 2025 20:19:55 +0000 (21:19 +0100)
committerRalph Boehme <slow@samba.org>
Thu, 27 Mar 2025 05:37:44 +0000 (05:37 +0000)
The adjusted test passes against Windows Server 2022.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13594

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
selftest/knownfail.d/samba3.base.delaywrite [new file with mode: 0644]
source4/torture/basic/delaywrite.c

diff --git a/selftest/knownfail.d/samba3.base.delaywrite b/selftest/knownfail.d/samba3.base.delaywrite
new file mode 100644 (file)
index 0000000..8a1b25f
--- /dev/null
@@ -0,0 +1 @@
+^samba3.base.delaywrite.finfo update on close\(fileserver_smb1\)
index 3b628ff4a82d77df331604edc7cf4c6aee9c2879..4e41232ba9aa962afc29e34cce96d11f76ded552 100644 (file)
@@ -1206,16 +1206,9 @@ static bool test_finfo_after_write(struct torture_context *tctx, struct smbcli_s
                goto done;
        }
 
-       if (finfo1.basic_info.out.access_time !=
-           finfo2.basic_info.out.access_time) {
-               torture_result(tctx, TORTURE_FAIL, __location__": access_time changed");
-               ret = false;
-               goto done;
-       }
-
-       if (finfo1.basic_info.out.write_time !=
+       if (finfo1.basic_info.out.write_time ==
            finfo2.basic_info.out.write_time) {
-               torture_result(tctx, TORTURE_FAIL, __location__": write_time changed:\n"
+               torture_result(tctx, TORTURE_FAIL, __location__": write_time unchanged:\n"
                                           "write time conn 1 = %s, conn 2 = %s", 
                       nt_time_string(tctx, finfo1.basic_info.out.write_time),
                       nt_time_string(tctx, finfo2.basic_info.out.write_time));
@@ -1223,9 +1216,9 @@ static bool test_finfo_after_write(struct torture_context *tctx, struct smbcli_s
                goto done;
        }
 
-       if (finfo1.basic_info.out.change_time !=
+       if (finfo1.basic_info.out.change_time ==
            finfo2.basic_info.out.change_time) {
-               torture_result(tctx, TORTURE_FAIL, __location__": change_time changed");
+               torture_result(tctx, TORTURE_FAIL, __location__": change_time unchanged");
                ret = false;
                goto done;
        }