NFSD: prevent underflow in nfssvc_decode_writeargs()

commit 184416d4b98509fb4c3d8fc3d6dc1437896cc159 upstream.

Smatch complains:

	fs/nfsd/nfsxdr.c:341 nfssvc_decode_writeargs()
	warn: no lower bound on 'args->len'

Change the type to unsigned to prevent this issue.

Cc: stable@vger.kernel.org
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/fs/nfsd/nfsproc.c b/fs/nfsd/nfsproc.c
index 536009e503871009c406faaac64c5569b8a9cdb6..fd5bb6f7f5f77fe616bc57cc21d9f39744e70bfd 100644 (file)
--- a/fs/nfsd/nfsproc.c
+++ b/fs/nfsd/nfsproc.c
@@ -207,7 +207,7 @@ nfsd_proc_write(struct svc_rqst *rqstp, struct nfsd_writeargs *argp,
        int     stable = 1;
        unsigned long cnt = argp->len;
 
-       dprintk("nfsd: WRITE    %s %d bytes at %d\n",
+       dprintk("nfsd: WRITE    %s %u bytes at %d\n",
                SVCFH_fmt(&argp->fh),
                argp->len, argp->offset);
 

diff --git a/fs/nfsd/xdr.h b/fs/nfsd/xdr.h
index 4f0481d638048feda597888969712ab1d2dd3a08..8c78b56a935023e67594b4f1bdce1b66881d015a 100644 (file)
--- a/fs/nfsd/xdr.h
+++ b/fs/nfsd/xdr.h
@@ -32,7 +32,7 @@ struct nfsd_readargs {
 struct nfsd_writeargs {
        svc_fh                  fh;
        __u32                   offset;
-       int                     len;
+       __u32                   len;
        int                     vlen;
 };