]> git.ipfire.org Git - thirdparty/mkosi.git/commitdiff
Don't reverse list option values found in the same option
authorDaan De Meyer <daan.j.demeyer@gmail.com>
Wed, 9 Aug 2023 06:48:29 +0000 (08:48 +0200)
committerLuca Boccassi <luca.boccassi@gmail.com>
Wed, 9 Aug 2023 10:10:29 +0000 (11:10 +0100)
Items from earlier settings should take precedence over items from
later settings, but that doesn't mean we should reverse items found
in the same setting.

Fixes #1707

mkosi/config.py

index e3d978bb1689dc6364025e60a1da8cbe09a50d06..ae77dace1c1905a164828804261e3d3ab01cf891 100644 (file)
@@ -361,6 +361,8 @@ def config_make_list_parser(delimiter: str,
         else:
             values = value.replace(delimiter, "\n").split("\n")
 
+        new = []
+
         for v in values:
             if not v:
                 continue
@@ -373,9 +375,9 @@ def config_make_list_parser(delimiter: str,
                 if fnmatch.fnmatchcase(v, i):
                     break
             else:
-                l.insert(0, parse(v))
+                new.append(parse(v))
 
-        return l
+        return new + l
 
     return config_parse_list