]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
net: wan: fsl_ucc_hdlc: fix uhdlc_memclean
authorHolger Brunck <holger.brunck@hitachienergy.com>
Wed, 29 Apr 2026 11:42:07 +0000 (13:42 +0200)
committerJakub Kicinski <kuba@kernel.org>
Sat, 2 May 2026 17:14:00 +0000 (10:14 -0700)
Unmapping of uf_regs is done from ucc_fast_free and doesn't need to be
done explicitly. If already unmapped ucc_fast_free will crash.

Fixes: c19b6d246a35 ("drivers/net: support hdlc function for QE-UCC")
Signed-off-by: Holger Brunck <holger.brunck@hitachienergy.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/wan/fsl_ucc_hdlc.c

index 3bd57527b1be63eded1900c40ab60c54ba7aaf5e..8155e92af14e23d3e83625de3d18ece56dbac006 100644 (file)
@@ -773,11 +773,6 @@ static void uhdlc_memclean(struct ucc_hdlc_private *priv)
        kfree(priv->tx_skbuff);
        priv->tx_skbuff = NULL;
 
-       if (priv->uf_regs) {
-               iounmap(priv->uf_regs);
-               priv->uf_regs = NULL;
-       }
-
        if (priv->uccf) {
                ucc_fast_free(priv->uccf);
                priv->uccf = NULL;