]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
PCI/MSI: Unmap MSI-X region on error
authorHaoxiang Li <lihaoxiang@isrc.iscas.ac.cn>
Sun, 25 Jan 2026 14:44:52 +0000 (22:44 +0800)
committerThomas Gleixner <tglx@kernel.org>
Mon, 26 Jan 2026 08:46:48 +0000 (09:46 +0100)
msix_capability_init() fails to unmap the MSI-X region if
msix_setup_interrupts() fails.

Add the missing iounmap() for that error path.

[ tglx: Massaged change log ]

Signed-off-by: Haoxiang Li <lihaoxiang@isrc.iscas.ac.cn>
Signed-off-by: Thomas Gleixner <tglx@kernel.org>
Link: https://patch.msgid.link/20260125144452.2103812-1-lihaoxiang@isrc.iscas.ac.cn
drivers/pci/msi/msi.c

index 34d664139f48fc03857a58d2e26a09f1744d6e60..e010ecd9f90dde998fec30c4b87cee6c86044141 100644 (file)
@@ -737,7 +737,7 @@ static int msix_capability_init(struct pci_dev *dev, struct msix_entry *entries,
 
        ret = msix_setup_interrupts(dev, entries, nvec, affd);
        if (ret)
-               goto out_disable;
+               goto out_unmap;
 
        /* Disable INTX */
        pci_intx_for_msi(dev, 0);
@@ -758,6 +758,8 @@ static int msix_capability_init(struct pci_dev *dev, struct msix_entry *entries,
        pcibios_free_irq(dev);
        return 0;
 
+out_unmap:
+       iounmap(dev->msix_base);
 out_disable:
        dev->msix_enabled = 0;
        pci_msix_clear_and_set_ctrl(dev, PCI_MSIX_FLAGS_MASKALL | PCI_MSIX_FLAGS_ENABLE, 0);