]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s3:share_mode_lock: add missing 'goto done' in share_mode_cleanup_disconnected()
authorStefan Metzmacher <metze@samba.org>
Fri, 28 Aug 2020 13:56:35 +0000 (15:56 +0200)
committerVolker Lendecke <vl@samba.org>
Mon, 31 Aug 2020 11:57:01 +0000 (11:57 +0000)
When cleanup_disconnected_lease() fails we should stop,
at least we do that if brl_cleanup_disconnected() fails.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14428

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
source3/locking/share_mode_lock.c

index a1a7b9793cfa7831f13449004c15bf8bc71b255c..965c5ab188377397ddbbe6b85fadc2fc526f6a74 100644 (file)
@@ -1694,6 +1694,7 @@ bool share_mode_cleanup_disconnected(struct file_id fid,
                          (data->stream_name == NULL)
                          ? "" : data->stream_name,
                          open_persistent_id);
+               goto done;
        }
 
        ok = brl_cleanup_disconnected(fid, open_persistent_id);