]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
wifi: ath12k: Abort scan before removing link interface to prevent duplicate deletion
authorLingbo Kong <quic_lingbok@quicinc.com>
Fri, 18 Apr 2025 06:40:08 +0000 (14:40 +0800)
committerJeff Johnson <jeff.johnson@oss.qualcomm.com>
Fri, 16 May 2025 19:38:54 +0000 (12:38 -0700)
Currently, when ath12k performs the remove link interface operation, if
there is an ongoing scan operation on the arvif, ath12k may execute the
remove link interface operation multiple times on the same arvif. This
occurs because, during the remove link operation, if a scan operation is
present on the arvif, ath12k may receive a WMI_SCAN_EVENT_COMPLETED event
from the firmware. Upon receiving this event, ath12k will continue to
execute the ath12k_scan_vdev_clean_work() function, performing the remove
link interface operation on the same arvif again.

To address this issue, before executing the remove link interface
operation, ath12k needs to check if there is an ongoing scan operation on
the current arvif. If such an operation exists, it should be aborted.

Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3

Signed-off-by: Lingbo Kong <quic_lingbok@quicinc.com>
Tested-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Reviewed-by: Vasanthakumar Thiagarajan <vasanthakumar.thiagarajan@oss.qualcomm.com>
Link: https://patch.msgid.link/20250418064008.7172-1-quic_lingbok@quicinc.com
Signed-off-by: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
drivers/net/wireless/ath/ath12k/mac.c

index af0164f088243564c39b71a7e30c1f12ccae26a6..0fb4b7bc845b9320d9c4cf804351b2739369b895 100644 (file)
@@ -10305,6 +10305,11 @@ ath12k_mac_op_unassign_vif_chanctx(struct ieee80211_hw *hw,
                reinit_completion(&ar->completed_11d_scan);
                ar->state_11d = ATH12K_11D_PREPARING;
        }
+
+       if (ar->scan.arvif == arvif && ar->scan.state == ATH12K_SCAN_RUNNING) {
+               ath12k_scan_abort(ar);
+               ar->scan.arvif = NULL;
+       }
 }
 
 static int