]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
virNWFilterRuleDefToRuleInst: `virHashNew` cannot return NULL
authorTim Wiederhake <twiederh@redhat.com>
Tue, 6 Jul 2021 11:26:10 +0000 (13:26 +0200)
committerTim Wiederhake <twiederh@redhat.com>
Wed, 14 Jul 2021 13:36:27 +0000 (15:36 +0200)
Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
tests/nwfilterxml2firewalltest.c

index bdfe85818578c684130cb3530c9337c8aa85535b..75a70e997224a4f2d4e46284e80c01862dbf92c3 100644 (file)
@@ -208,8 +208,8 @@ virNWFilterRuleDefToRuleInst(virNWFilterDef *def,
     ruleinst->chainPriority = def->chainPriority;
     ruleinst->def = rule;
     ruleinst->priority = rule->priority;
-    if (!(ruleinst->vars = virHashNew(virNWFilterVarValueHashFree)))
-        goto cleanup;
+    ruleinst->vars = virHashNew(virNWFilterVarValueHashFree);
+
     if (virNWFilterHashTablePutAll(vars, ruleinst->vars) < 0)
         goto cleanup;