char: tpm: cr50: Remove IRQF_ONESHOT

Passing IRQF_ONESHOT ensures that the interrupt source is masked until
the secondary (threaded) handler is done. If only a primary handler is
used then the flag makes no sense because the interrupt can not fire
(again) while its handler is running.

The flag also prevents force-threading of the primary handler and the
irq-core will warn about this.

Remove IRQF_ONESHOT from irqflags.

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Thomas Gleixner <tglx@kernel.org>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
Link: https://patch.msgid.link/20260128095540.863589-10-bigeasy@linutronix.de

diff --git a/drivers/char/tpm/tpm_tis_i2c_cr50.c b/drivers/char/tpm/tpm_tis_i2c_cr50.c
index fc6891a0b6936de9679474932bdd5c5f88e735a4..b48cacacc0664a81ef0ebe02cf41455d42cd7304 100644 (file)
--- a/drivers/char/tpm/tpm_tis_i2c_cr50.c
+++ b/drivers/char/tpm/tpm_tis_i2c_cr50.c
@@ -749,8 +749,7 @@ static int tpm_cr50_i2c_probe(struct i2c_client *client)
 
        if (client->irq > 0) {
                rc = devm_request_irq(dev, client->irq, tpm_cr50_i2c_int_handler,
-                                     IRQF_TRIGGER_FALLING | IRQF_ONESHOT |
-                                     IRQF_NO_AUTOEN,
+                                     IRQF_TRIGGER_FALLING | IRQF_NO_AUTOEN,
                                      dev->driver->name, chip);
                if (rc < 0) {
                        dev_err(dev, "Failed to probe IRQ %d\n", client->irq);

diff --git a/drivers/char/tpm/tpm_tis_spi_cr50.c b/drivers/char/tpm/tpm_tis_spi_cr50.c
index f4937280e940615d5ad9c9dee61c31d1435e6304..32920b4cecfb44729bd4063df47fc5000452c753 100644 (file)
--- a/drivers/char/tpm/tpm_tis_spi_cr50.c
+++ b/drivers/char/tpm/tpm_tis_spi_cr50.c
@@ -287,7 +287,7 @@ int cr50_spi_probe(struct spi_device *spi)
        if (spi->irq > 0) {
                ret = devm_request_irq(&spi->dev, spi->irq,
                                       cr50_spi_irq_handler,
-                                      IRQF_TRIGGER_RISING | IRQF_ONESHOT,
+                                      IRQF_TRIGGER_RISING,
                                       "cr50_spi", cr50_phy);
                if (ret < 0) {
                        if (ret == -EPROBE_DEFER)