]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
media: i2c: ov8856: parse and register V4L2 device tree properties
authorAlexander Koskovich <akoskovich@pm.me>
Thu, 12 Mar 2026 17:16:28 +0000 (17:16 +0000)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Tue, 24 Mar 2026 10:58:02 +0000 (11:58 +0100)
Parse V4L2 device tree properties and register controls for them.

Signed-off-by: Alexander Koskovich <akoskovich@pm.me>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/i2c/ov8856.c

index dd01e1d515ff6d715de3dc4676365ad680ff4117..8bedb47cd7cf6a578b6ce9ce96b1fcdaa2c72d7a 100644 (file)
@@ -1887,12 +1887,14 @@ static const struct v4l2_ctrl_ops ov8856_ctrl_ops = {
 
 static int ov8856_init_controls(struct ov8856 *ov8856)
 {
+       struct i2c_client *client = v4l2_get_subdevdata(&ov8856->sd);
+       struct v4l2_fwnode_device_properties props;
        struct v4l2_ctrl_handler *ctrl_hdlr;
        s64 exposure_max, h_blank;
        int ret;
 
        ctrl_hdlr = &ov8856->ctrl_handler;
-       ret = v4l2_ctrl_handler_init(ctrl_hdlr, 8);
+       ret = v4l2_ctrl_handler_init(ctrl_hdlr, 10);
        if (ret)
                return ret;
 
@@ -1956,6 +1958,15 @@ static int ov8856_init_controls(struct ov8856 *ov8856)
                goto err_ctrl_handler_free;
        }
 
+       ret = v4l2_fwnode_device_parse(&client->dev, &props);
+       if (ret)
+               goto err_ctrl_handler_free;
+
+       ret = v4l2_ctrl_new_fwnode_properties(ctrl_hdlr, &ov8856_ctrl_ops,
+                                             &props);
+       if (ret)
+               goto err_ctrl_handler_free;
+
        ov8856->sd.ctrl_handler = ctrl_hdlr;
 
        return 0;