2005-02-12 Hollis Blanchard <hollis@penguinppc.org>

	* kern/partition.c (grub_partition_probe): Clear `grub_errno' and
	return 0 if `grub_errno' is GRUB_ERR_BAD_PART_TABLE.
	(part_map_iterate): Clear `grub_errno' and return 0 if
	`partmap->iterate' returns GRUB_ERR_BAD_PART_TABLE.
	* partmap/amiga.c (amiga_partition_map_iterate): Return
	GRUB_ERR_BAD_PART_TABLE if no partition map magic is found.
	* partmap/apple.c (apple_partition_map_iterate): Likewise.

diff --git a/ChangeLog b/ChangeLog
index a457c21ae0ebffb9e3c27c73584a8f2ff70a2c61..1a1732cf16681b414b51e18b3d326f7252ababf5 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,13 @@
+2005-02-12  Hollis Blanchard  <hollis@penguinppc.org>
+
+       * kern/partition.c (grub_partition_probe): Clear `grub_errno' and
+       return 0 if `grub_errno' is GRUB_ERR_BAD_PART_TABLE. 
+       (part_map_iterate): Clear `grub_errno' and return 0 if
+       `partmap->iterate' returns GRUB_ERR_BAD_PART_TABLE. 
+       * partmap/amiga.c (amiga_partition_map_iterate): Return
+       GRUB_ERR_BAD_PART_TABLE if no partition map magic is found.
+       * partmap/apple.c (apple_partition_map_iterate): Likewise.
+
 2005-02-01  Guillem Jover  <guillem@hadrons.org>
 
        * loader/i386/pc/multiboot_normal.c (GRUB_MOD_INIT): Fix module

diff --git a/kern/partition.c b/kern/partition.c
index be8bdab3ac57ffd174eea2598a84d14289d6aff4..fd314875bc0846d3ee98d9df90932b6309a1115a 100644 (file)
--- a/kern/partition.c
+++ b/kern/partition.c
@@ -56,20 +56,28 @@ grub_partition_t
 grub_partition_probe (struct grub_disk *disk, const char *str)
 {
   grub_partition_t part;
-  
+
   auto int part_map_probe (const grub_partition_map_t partmap);
-  
+
   int part_map_probe (const grub_partition_map_t partmap)
     {
       part = partmap->probe (disk, str);
       if (part)
        return 1;
-      return 0;
+
+      if (grub_errno == GRUB_ERR_BAD_PART_TABLE)
+       {
+         /* Continue to next partition map type.  */
+         grub_errno = GRUB_ERR_NONE;
+         return 0;
+       }
+
+      return 1;
     }
 
   /* Use the first partition map type found.  */
   grub_partition_map_iterate (part_map_probe);
-  
+
   return part;
 }
 
@@ -78,12 +86,21 @@ grub_partition_iterate (struct grub_disk *disk,
                        int (*hook) (const grub_partition_t partition))
 {
   auto int part_map_iterate (const grub_partition_map_t partmap);
-  
+
   int part_map_iterate (const grub_partition_map_t partmap)
     {
-      return partmap->iterate (disk, hook);
+      grub_err_t err = partmap->iterate (disk, hook);
+
+      if (err == GRUB_ERR_BAD_PART_TABLE)
+       {
+         /* Continue to next partition map type.  */
+         grub_errno = GRUB_ERR_NONE;
+         return 0;
+       }
+
+      return 1;
     }
-  
+
   grub_partition_map_iterate (part_map_iterate);
   return grub_errno;
 }

diff --git a/partmap/amiga.c b/partmap/amiga.c
index 4712415699d059cff1fa180fbe1137417041e2f1..b19a559d0d50e23486f8cf18fa41c2764d2fb6e7 100644 (file)
--- a/partmap/amiga.c
+++ b/partmap/amiga.c
@@ -102,6 +102,10 @@ amiga_partition_map_iterate (grub_disk_t disk,
          break;
        }
     }
+
+  if (next == -1)
+    return grub_error (GRUB_ERR_BAD_PART_TABLE,
+                      "Amiga partition map not found.");
   
   /* The end of the partition list is marked using "-1".  */
   while (next != -1)

diff --git a/partmap/apple.c b/partmap/apple.c
index 5510a0588d4d539a1bdf196bc98b61d1066e5d7b..7e4a413d0cecd92dcea0803da373915c81027398 100644 (file)
--- a/partmap/apple.c
+++ b/partmap/apple.c
@@ -108,7 +108,7 @@ apple_partition_map_iterate (grub_disk_t disk,
   raw.partition = 0;
 
   part.partmap = &grub_apple_partition_map;
-  
+
   for (;;)
     {
       if (grub_disk_read (&raw, pos / GRUB_DISK_SECTOR_SIZE,
@@ -134,6 +134,10 @@ apple_partition_map_iterate (grub_disk_t disk,
       partno++;
     }
 
+  if ((pos / GRUB_DISK_SECTOR_SIZE) == 0)
+    return grub_error (GRUB_ERR_BAD_PART_TABLE,
+                      "Apple partition map not found.");
+
   return 0;
 }
 
@@ -178,7 +182,6 @@ apple_partition_map_probe (grub_disk_t disk, const char *str)
  fail:
   grub_free (p);
   return 0;
-
 }