[efi] Use long forms of device paths in debug messages

We currently call ConvertDevicePathToText() with DisplayOnly=TRUE when
constructing a device path to appear within a debug message.  For
ATAPI device paths, this will unfortunately omit some key information:
the textual representation will not indicate which ATA bus or drive is
represented.  This can lead to misleading debug messages that appear
to refer to identical devices.

Fix by setting DisplayOnly=FALSE to select the long form of device
path textual representations.

Signed-off-by: Michael Brown <mcb30@ipxe.org>

diff --git a/src/interface/efi/efi_debug.c b/src/interface/efi/efi_debug.c
index ad79f0d370b2570b1faaca49a3ae467771dd2671..52efebe5f0730707b8e3a7e967ab7aea13f8edee 100644 (file)
--- a/src/interface/efi/efi_debug.c
+++ b/src/interface/efi/efi_debug.c
@@ -479,7 +479,7 @@ efi_devpath_text ( EFI_DEVICE_PATH_PROTOCOL *path ) {
        }
 
        /* Convert path to a textual representation */
-       wtext = efidpt->ConvertDevicePathToText ( path, TRUE, FALSE );
+       wtext = efidpt->ConvertDevicePathToText ( path, FALSE, FALSE );
        if ( ! wtext )
                return NULL;