]> git.ipfire.org Git - thirdparty/openssl.git/commitdiff
Remove a redundant TODO
authorMatt Caswell <matt@openssl.org>
Fri, 22 Jul 2022 13:23:25 +0000 (14:23 +0100)
committerMatt Caswell <matt@openssl.org>
Thu, 18 Aug 2022 15:38:13 +0000 (16:38 +0100)
If read_ahead data is left over when a record layer closes down, there is
already code present to push into the "next" BIO. So the TODO removed here
is no longer relevant.

Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/18132)

ssl/record/methods/tls_common.c

index 8b541061ba18f9fbf27f58d21e30eeca48cafa75..4c999c52e83443cad3fbbfa6f0ebaa2b1a0b9898 100644 (file)
@@ -1080,10 +1080,6 @@ tls_int_new_record_layer(OSSL_LIB_CTX *libctx, const char *propq, int vers,
          * that is destined for a higher protection level. To simplify the logic
          * we don't support that at this stage.
          */
-        /*
-         * TODO(RECLAYER): Handle the case of read_ahead at the application
-         * level and a key update/reneg occurs.
-         */
         p = OSSL_PARAM_locate_const(options, OSSL_LIBSSL_RECORD_LAYER_PARAM_READ_AHEAD);
         if (p != NULL && !OSSL_PARAM_get_int(p, &rl->read_ahead)) {
             RLAYERfatal(rl, SSL_AD_INTERNAL_ERROR, SSL_R_FAILED_TO_GET_PARAMETER);