tools/rmmod: minor getopt tweaks

Adjust the loop to follow the in-documentation example.

Namely, we don't need the unused idx and removing the seemingly
infinite loop helps static analysers better reason about the code flow.

Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Link: https://github.com/kmod-project/kmod/pull/195
Signed-off-by: Lucas De Marchi <lucas.de.marchi@gmail.com>

diff --git a/tools/rmmod.c b/tools/rmmod.c
index 1315eda2bda0b67a0317b13fde2fe61c3fe42c44..0e00edec2671d837292c0487f03524cae3bd66ac 100644 (file)
--- a/tools/rmmod.c
+++ b/tools/rmmod.c
@@ -96,13 +96,9 @@ static int do_rmmod(int argc, char *argv[])
        int verbose = LOG_ERR;
        int use_syslog = 0;
        int flags = 0;
-       int i, r = 0;
+       int i, c, r = 0;
 
-       for (;;) {
-               int c, idx = 0;
-               c = getopt_long(argc, argv, cmdopts_s, cmdopts, &idx);
-               if (c == -1)
-                       break;
+       while ((c = getopt_long(argc, argv, cmdopts_s, cmdopts, NULL)) != -1) {
                switch (c) {
                case 'f':
                        flags |= KMOD_REMOVE_FORCE;