Check for error return from fr_sbuff_in_bstrncpy() (CID #1503901)

diff --git a/src/modules/rlm_smtp/rlm_smtp.c b/src/modules/rlm_smtp/rlm_smtp.c
index c267bba869ad9a17b99bd53b2bf5879ab7a25e39..93b45fda99dab6528022478dd4a0054d0f3b9e36 100644 (file)
--- a/src/modules/rlm_smtp/rlm_smtp.c
+++ b/src/modules/rlm_smtp/rlm_smtp.c
@@ -410,8 +410,10 @@ static int str_to_attachments(fr_mail_ctx_t *uctx, curl_mime *mime, char const *
        }
 
        /* Copy the filename into the buffer */
-       /* coverity[check_return] */
-       fr_sbuff_in_bstrncpy(path_buffer, str, len);
+       if (fr_sbuff_in_bstrncpy(path_buffer, str, len) < 0) {
+               RDEBUG2("Cannot copy filename");
+               return 0;
+       }
 
        /* Add the file attachment as a mime encoded part */
        part = curl_mime_addpart(mime);