]> git.ipfire.org Git - thirdparty/libcgroup.git/commitdiff
config.c: fix memory leak in convert_controller_versions()
authorKamalesh Babulal <kamalesh.babulal@oracle.com>
Mon, 12 Jun 2023 10:06:03 +0000 (15:36 +0530)
committerTom Hromatka <tom.hromatka@oracle.com>
Mon, 12 Jun 2023 14:07:38 +0000 (08:07 -0600)
Fix memory leak warning in convert_controller_versions(), reported by
Coverity tool:

CID 313911 (#1 of 1): Resource leak (RESOURCE_LEAK)9. leaked_storage:
Variable cgrp_cpy going out of scope leaks the storage it points to.

struct cgroup cgrp_cpy was not free'd in the success path, fix it.

Signed-off-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
src/config.c

index 83b7a955e9c15d8b6cfb5bc0dd809d119d662502..767857841c796851ddb8c4389a5a1f44770efc4c 100644 (file)
@@ -852,7 +852,8 @@ next_controller:
                cgroup_free_controller(cgc);
                cgrp_cpy->index = 0;
        }
-       return 0;
+
+       ret = 0;
 err:
        cgroup_free(&convert_cgrp);
        cgroup_free(&cgrp_cpy);