]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
fpga: prevent integer overflow in dfl_feature_ioctl_set_irq()
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 1 Sep 2022 05:18:45 +0000 (08:18 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 24 Oct 2022 07:57:51 +0000 (09:57 +0200)
[ Upstream commit 939bc5453b8cbdde9f1e5110ce8309aedb1b501a ]

The "hdr.count * sizeof(s32)" multiplication can overflow on 32 bit
systems leading to memory corruption.  Use array_size() to fix that.

Fixes: 322b598be4d9 ("fpga: dfl: introduce interrupt trigger setting API")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Xu Yilun <yilun.xu@intel.com>
Link: https://lore.kernel.org/r/YxBAtYCM38dM7yzI@kili
Signed-off-by: Xu Yilun <yilun.xu@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/fpga/dfl.c

index 6bff39ff21a0dd74a04922ae74b4f1b6fd40dc65..eabaf495a481e46f820a201ded5dca20b7a8c425 100644 (file)
@@ -1866,7 +1866,7 @@ long dfl_feature_ioctl_set_irq(struct platform_device *pdev,
                return -EINVAL;
 
        fds = memdup_user((void __user *)(arg + sizeof(hdr)),
-                         hdr.count * sizeof(s32));
+                         array_size(hdr.count, sizeof(s32)));
        if (IS_ERR(fds))
                return PTR_ERR(fds);