]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
media: renesas: vsp1: histo: Fix size enumeration
authorLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Wed, 18 Mar 2026 23:59:04 +0000 (01:59 +0200)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Wed, 25 Mar 2026 09:25:49 +0000 (10:25 +0100)
The histogram supports size enumeration on the sink pad only, as the
source pad outputs a metadata format. The correct error code when
enumeration is not supported is -ENOTTY, not -EINVAL. Fix it.

Tested-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> # HiHope RZ/G2M
Link: https://patch.msgid.link/20260318235907.831556-11-laurent.pinchart+renesas@ideasonboard.com
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/platform/renesas/vsp1/vsp1_histo.c

index f97aecb22058179a5ade4bd6d05ecedea114d7fe..313b9f3ce0f169200fbf9e1805c8173cc31e7dea 100644 (file)
@@ -183,7 +183,7 @@ static int histo_enum_frame_size(struct v4l2_subdev *subdev,
                                 struct v4l2_subdev_frame_size_enum *fse)
 {
        if (fse->pad != HISTO_PAD_SINK)
-               return -EINVAL;
+               return -ENOTTY;
 
        return vsp1_subdev_enum_frame_size(subdev, sd_state, fse);
 }