]> git.ipfire.org Git - thirdparty/glibc.git/commitdiff
Minor: don't call _dl_debug_update (which can have side effects) inside assert
authorPaul Pluzhnikov <ppluzhnikov@google.com>
Sat, 25 Mar 2023 21:27:01 +0000 (21:27 +0000)
committerPaul Pluzhnikov <ppluzhnikov@google.com>
Sun, 26 Mar 2023 00:22:30 +0000 (00:22 +0000)
elf/dl-open.c

index 91a2d8a538d68ef8898b172cc767781e0d850c44..2d985e21d85458e80f3e16421ea436244dd95480 100644 (file)
@@ -578,7 +578,9 @@ dl_open_worker_begin (void *a)
       if ((mode & RTLD_GLOBAL) && new->l_global == 0)
        add_to_global_update (new);
 
-      assert (_dl_debug_update (args->nsid)->r_state == RT_CONSISTENT);
+      const int r_state __attribute__ ((unused))
+        = _dl_debug_update (args->nsid)->r_state;
+      assert (r_state == RT_CONSISTENT);
 
       return;
     }
@@ -927,7 +929,9 @@ no more namespaces available for dlmopen()"));
       _dl_signal_exception (errcode, &exception, NULL);
     }
 
-  assert (_dl_debug_update (args.nsid)->r_state == RT_CONSISTENT);
+  const int r_state __attribute__ ((unused))
+    = _dl_debug_update (args.nsid)->r_state;
+  assert (r_state == RT_CONSISTENT);
 
   /* Release the lock.  */
   __rtld_lock_unlock_recursive (GL(dl_load_lock));