src/abstraction-common.h: fix checkpatch.pl warnings

Fix all of the warnings/errors reported by Linux Kernel's checkpatch.pl,
except SPDX_LICENSE_TAG, USE_NEGATIVE_ERRNO types.  It also introduces
reverse xmas tree local variable declarations and header file
reordering.

In summary, this patch fixes the following checkpatch.pl
recommendations:
total: 0 errors, 4 warnings, 150 lines checked

Signed-off-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>

diff --git a/src/abstraction-common.h b/src/abstraction-common.h
index 960d1575d729607b8878a53405e0b72662edd2fb..efe8f1862f9fbc83e28955249fb4d52a60865644 100644 (file)
--- a/src/abstraction-common.h
+++ b/src/abstraction-common.h
@@ -26,6 +26,7 @@ extern "C" {
 #endif
 
 #include "config.h"
+
 #include <libcgroup.h>
 #include "libcgroup-internal.h"
 
@@ -37,11 +38,11 @@ extern "C" {
  * @param out_value Pointer to hold the output long value
  *
  * @return 0 on success,
- *        ECGFAIL if the conversion to long failed,
- *        ECGINVAL upon an invalid parameter
+ *        ECGFAIL if the conversion to long failed,
+ *        ECGINVAL upon an invalid parameter
  */
 int cgroup_strtol(const char * const in_str, int base,
-                 long int * const out_value);
+                 long * const out_value);
 
 /**
  * Convert an integer setting to another integer setting