smb: client: get rid of kstrdup() when parsing pass2 mount option

Steal string reference from @param->string rather than duplicating it.

Signed-off-by: Paulo Alcantara (Red Hat) <pc@manguebit.org>
Reviewed-by: David Howells <dhowells@redhat.com>
Signed-off-by: Steve French <stfrench@microsoft.com>

diff --git a/fs/smb/client/fs_context.c b/fs/smb/client/fs_context.c
index c332d110704a284ed0b99e7740a544e26f7e4a7d..f29efc03e8050bb5e23c684e44ca207dc2c10639 100644 (file)
--- a/fs/smb/client/fs_context.c
+++ b/fs/smb/client/fs_context.c
@@ -1489,12 +1489,7 @@ static int smb3_fs_context_parse_param(struct fs_context *fc,
                ctx->password2 = NULL;
                if (strlen(param->string) == 0)
                        break;
-
-               ctx->password2 = kstrdup(param->string, GFP_KERNEL);
-               if (ctx->password2 == NULL) {
-                       cifs_errorf(fc, "OOM when copying password2 string\n");
-                       goto cifs_parse_mount_err;
-               }
+               ctx->password2 = no_free_ptr(param->string);
                break;
        case Opt_ip:
                if (strlen(param->string) == 0) {