push 'outgoing' flag from sig_XXX up to chan_dahdi

'p->outgoing' in chan_dahdi and sig_analog wern't kept in sync, particulary FXS ast_hangup didn't clear the 'outgoing' flag.
sig_pri and sig_ss7 were keeping 'outgoing' flag insync.

Now provides a callback for all the low level sig_XXX modules.

(issue ASTERISK-19316)

alecdavis (license 585)
Reported by: Jeremy Pepper
Tested by: alecdavis

Review: https://reviewboard.asterisk.org/r/1747/

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@355850 65c4cc65-6c06-0410-ace0-fbb531ad65f3

diff --git a/channels/chan_dahdi.c b/channels/chan_dahdi.c
index 5d9600db6ffec9ccc6d6de897784fafdeccd9d55..4a4cca62d8b7c8babf2ba634d6efe5ca540545f3 100644 (file)
--- a/channels/chan_dahdi.c
+++ b/channels/chan_dahdi.c
@@ -2240,6 +2240,13 @@ static void my_set_dialing(void *pvt, int is_dialing)
        p->dialing = is_dialing;
 }
 
+static void my_set_outgoing(void *pvt, int is_outgoing)
+{
+       struct dahdi_pvt *p = pvt;
+
+       p->outgoing = is_outgoing;
+}
+
 #if defined(HAVE_PRI) || defined(HAVE_SS7)
 static void my_set_digital(void *pvt, int is_digital)
 {
@@ -3362,6 +3369,7 @@ static struct sig_pri_callback dahdi_pri_callbacks =
        .fixup_chans = my_pri_fixup_chans,
        .set_alarm = my_set_alarm,
        .set_dialing = my_set_dialing,
+       .set_outgoing = my_set_outgoing,
        .set_digital = my_set_digital,
        .set_callerid = my_set_callerid,
        .set_dnid = my_set_dnid,
@@ -3532,6 +3540,7 @@ static struct sig_ss7_callback dahdi_ss7_callbacks =
        .handle_link_exception = my_handle_link_exception,
        .set_alarm = my_set_alarm,
        .set_dialing = my_set_dialing,
+       .set_outgoing = my_set_outgoing,
        .set_digital = my_set_digital,
        .set_inservice = my_set_inservice,
        .set_locallyblocked = my_set_locallyblocked,
@@ -3673,6 +3682,7 @@ static struct analog_callback dahdi_analog_callbacks =
        .set_cadence = my_set_cadence,
        .set_alarm = my_set_alarm,
        .set_dialing = my_set_dialing,
+       .set_outgoing = my_set_outgoing,
        .set_ringtimeout = my_set_ringtimeout,
        .set_waitingfordt = my_set_waitingfordt,
        .check_waitingfordt = my_check_waitingfordt,

diff --git a/channels/sig_analog.c b/channels/sig_analog.c
index 79f22895bb6057a734714b67924e0192d339acbd..cbc09cd512e8ec5519b9a524a02a8075f3174dee 100644 (file)
--- a/channels/sig_analog.c
+++ b/channels/sig_analog.c
@@ -512,6 +512,14 @@ static int analog_on_hook(struct analog_pvt *p)
        return -1;
 }
 
+static void analog_set_outgoing(struct analog_pvt *p, int is_outgoing)
+{
+       p->outgoing = is_outgoing;
+       if (p->calls->set_outgoing) {
+               p->calls->set_outgoing(p->chan_pvt, is_outgoing);
+       }
+}
+
 static int analog_check_for_conference(struct analog_pvt *p)
 {
        if (p->calls->check_for_conference) {
@@ -793,11 +801,11 @@ struct ast_channel * analog_request(struct analog_pvt *p, int *callwait, const s
                }
        }
 
-       p->outgoing = 1;
+       analog_set_outgoing(p, 1);
        ast = analog_new_ast_channel(p, AST_STATE_RESERVED, 0,
                p->owner ? ANALOG_SUB_CALLWAIT : ANALOG_SUB_REAL, requestor);
        if (!ast) {
-               p->outgoing = 0;
+               analog_set_outgoing(p, 0);
        }
        return ast;
 }
@@ -1023,7 +1031,7 @@ int analog_call(struct analog_pvt *p, struct ast_channel *ast, char *rdest, int
        }
 
        p->dialednone = 0;
-       p->outgoing = 1;
+       analog_set_outgoing(p, 1);
 
        mysig = p->sig;
        if (p->outsigmod > -1) {
@@ -1426,7 +1434,7 @@ int analog_hangup(struct analog_pvt *p, struct ast_channel *ast)
                analog_set_ringtimeout(p, 0);
                analog_set_confirmanswer(p, 0);
                analog_set_pulsedial(p, 0);
-               p->outgoing = 0;
+               analog_set_outgoing(p, 0);
                p->onhooktime = time(NULL);
                p->cidrings = 1;
 

diff --git a/channels/sig_analog.h b/channels/sig_analog.h
index fd19b535282daafcd8244aab8b1272e8c0a48d07..dac5a0b552fadc26ff4f1ddf2dd2b7b3fbfafd39 100644 (file)
--- a/channels/sig_analog.h
+++ b/channels/sig_analog.h
@@ -223,6 +223,7 @@ struct analog_callback {
        void (* const set_cadence)(void *pvt, int *cidrings, struct ast_channel *chan);
        void (* const set_alarm)(void *pvt, int in_alarm);
        void (* const set_dialing)(void *pvt, int is_dialing);
+       void (* const set_outgoing)(void *pvt, int is_outgoing);
        void (* const set_ringtimeout)(void *pvt, int ringt);
        void (* const set_waitingfordt)(void *pvt, struct ast_channel *ast);
        int (* const check_waitingfordt)(void *pvt);

diff --git a/channels/sig_pri.c b/channels/sig_pri.c
index bc875ecffe84dab302dde3a8ba40fbc771e6d5bf..cf0798326cd7aaf0367b4d7827fa8653e99b319f 100644 (file)
--- a/channels/sig_pri.c
+++ b/channels/sig_pri.c
@@ -180,6 +180,14 @@ static void sig_pri_set_digital(struct sig_pri_chan *p, int is_digital)
        }
 }
 
+static void sig_pri_set_outgoing(struct sig_pri_chan *p, int is_outgoing)
+{
+       p->outgoing = is_outgoing;
+       if (p->calls->set_outgoing) {
+               p->calls->set_outgoing(p->chan_pvt, is_outgoing);
+       }
+}
+
 void sig_pri_set_alarm(struct sig_pri_chan *p, int in_alarm)
 {
        /*
@@ -993,10 +1001,10 @@ struct ast_channel *sig_pri_request(struct sig_pri_chan *p, enum sig_pri_law law
 
        ast_log(LOG_DEBUG, "%s %d\n", __FUNCTION__, p->channel);
 
-       p->outgoing = 1;
+       sig_pri_set_outgoing(p, 1);
        ast = sig_pri_new_ast_channel(p, AST_STATE_RESERVED, law, transfercapability, p->exten, requestor);
        if (!ast) {
-               p->outgoing = 0;
+               sig_pri_set_outgoing(p, 0);
        }
        return ast;
 }
@@ -6330,7 +6338,7 @@ int sig_pri_hangup(struct sig_pri_chan *p, struct ast_channel *ast)
                return 0;
        }
 
-       p->outgoing = 0;
+       sig_pri_set_outgoing(p, 0);
        sig_pri_set_digital(p, 0);      /* push up to parent for EC*/
 #if defined(HAVE_PRI_CALL_WAITING)
        if (p->is_call_waiting) {
@@ -6541,7 +6549,7 @@ int sig_pri_call(struct sig_pri_chan *p, struct ast_channel *ast, char *rdest, i
        }
 
        p->dialdest[0] = '\0';
-       p->outgoing = 1;
+       sig_pri_set_outgoing(p, 1);
 
        ast_copy_string(dest, rdest, sizeof(dest));
        AST_NONSTANDARD_APP_ARGS(args, dest, '/');

diff --git a/channels/sig_pri.h b/channels/sig_pri.h
index 67342be119b786713217b1f8b65f7a8cfb55458c..a29233a40894b3aae255b673719a7436f155082f 100644 (file)
--- a/channels/sig_pri.h
+++ b/channels/sig_pri.h
@@ -129,6 +129,7 @@ struct sig_pri_callback {
        void (* const set_alarm)(void *pvt, int in_alarm);
        void (* const set_dialing)(void *pvt, int is_dialing);
        void (* const set_digital)(void *pvt, int is_digital);
+       void (* const set_outgoing)(void *pvt, int is_outgoing);
        void (* const set_callerid)(void *pvt, const struct ast_party_caller *caller);
        void (* const set_dnid)(void *pvt, const char *dnid);
        void (* const set_rdnis)(void *pvt, const char *rdnis);

diff --git a/channels/sig_ss7.c b/channels/sig_ss7.c
index 8fe8aa836b70dd0687b21591161bdc5c6ea7c1e8..1af84e95b65afa00f70c00b61decb050912856b0 100644 (file)
--- a/channels/sig_ss7.c
+++ b/channels/sig_ss7.c
@@ -110,6 +110,14 @@ static void sig_ss7_set_digital(struct sig_ss7_chan *p, int is_digital)
        }
 }
 
+static void sig_ss7_set_outgoing(struct sig_ss7_chan *p, int is_outgoing)
+{
+       p->outgoing = is_outgoing;
+       if (p->calls->set_outgoing) {
+               p->calls->set_outgoing(p->chan_pvt, is_outgoing);
+       }
+}
+
 static void sig_ss7_set_inservice(struct sig_ss7_chan *p, int is_inservice)
 {
        if (p->calls->set_inservice) {
@@ -1560,7 +1568,7 @@ int sig_ss7_hangup(struct sig_ss7_chan *p, struct ast_channel *ast)
 
        p->owner = NULL;
        sig_ss7_set_dialing(p, 0);
-       p->outgoing = 0;
+       sig_ss7_set_outgoing(p, 0);
        p->progress = 0;
        p->rlt = 0;
        p->exten[0] = '\0';
@@ -1745,10 +1753,10 @@ struct ast_channel *sig_ss7_request(struct sig_ss7_chan *p, enum sig_ss7_law law
 {
        struct ast_channel *ast;
 
-       p->outgoing = 1;
+       sig_ss7_set_outgoing(p, 1);
        ast = sig_ss7_new_ast_channel(p, AST_STATE_RESERVED, law, transfercapability, p->exten, requestor);
        if (!ast) {
-               p->outgoing = 0;
+               sig_ss7_set_outgoing(p, 0);
 
                /* Release the allocated channel.  Only have to deal with the linkset lock. */
                ast_mutex_lock(&p->ss7->lock);

diff --git a/channels/sig_ss7.h b/channels/sig_ss7.h
index e198c9e09db1b649f00367e77125e7c59610cafc..36806eef02e778a5c241f7dc83afa0acbd1827a5 100644 (file)
--- a/channels/sig_ss7.h
+++ b/channels/sig_ss7.h
@@ -140,6 +140,7 @@ struct sig_ss7_callback {
        void (* const set_alarm)(void *pvt, int in_alarm);
        void (* const set_dialing)(void *pvt, int is_dialing);
        void (* const set_digital)(void *pvt, int is_digital);
+       void (* const set_outgoing)(void *pvt, int is_outgoing);
        void (* const set_inservice)(void *pvt, int is_inservice);
        void (* const set_locallyblocked)(void *pvt, int is_blocked);
        void (* const set_remotelyblocked)(void *pvt, int is_blocked);