]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
iio: st_pressure: st_accel: pass correct platform data to init
authorMichael Nosthoff <committed@heine.so>
Fri, 9 Mar 2018 09:02:45 +0000 (10:02 +0100)
committerSasha Levin <alexander.levin@microsoft.com>
Wed, 23 May 2018 01:33:52 +0000 (21:33 -0400)
[ Upstream commit 8b438686a001db64c21782d04ef68111e53c45d9 ]

Commit 7383d44b added a pointer pdata which get set to the default
platform_data when non was defined in the device. But it did not
pass this pointer to the st_sensors_init_sensor call but still
used the maybe uninitialized platform_data from dev.

This breaks initialization when no platform_data is given and
the optional st,drdy-int-pin devicetree option is not set.

This commit fixes this.

Cc: stable@vger.kernel.org
Fixes: 7383d44b ("iio: st_pressure: st_accel: Initialise sensor platform data properly")
Signed-off-by: Michael Nosthoff <committed@heine.so>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
drivers/iio/accel/st_accel_core.c
drivers/iio/pressure/st_pressure_core.c

index b5d043be41fb15477270e9e5647a5368f613cd38..2f94d1164730f221b48a2babb8acf4d995b3f872 100644 (file)
@@ -564,7 +564,7 @@ int st_accel_common_probe(struct iio_dev *indio_dev)
        if (!pdata)
                pdata = (struct st_sensors_platform_data *)&default_accel_pdata;
 
-       err = st_sensors_init_sensor(indio_dev, adata->dev->platform_data);
+       err = st_sensors_init_sensor(indio_dev, pdata);
        if (err < 0)
                return err;
 
index e74a4f685138e365f733c9b4a6c487b8b4517ade..c80bc75790e7a6e3787cd987298d6d4ee68095c5 100644 (file)
@@ -465,7 +465,7 @@ int st_press_common_probe(struct iio_dev *indio_dev)
        if (!pdata && press_data->sensor_settings->drdy_irq.addr)
                pdata = (struct st_sensors_platform_data *)&default_press_pdata;
 
-       err = st_sensors_init_sensor(indio_dev, press_data->dev->platform_data);
+       err = st_sensors_init_sensor(indio_dev, pdata);
        if (err < 0)
                return err;