]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
vboxDumpNetwork: use VIR_STEAL_PTR instead of VIR_STRDUP
authorJán Tomko <jtomko@redhat.com>
Fri, 23 Feb 2018 13:52:24 +0000 (14:52 +0100)
committerJán Tomko <jtomko@redhat.com>
Mon, 5 Mar 2018 11:57:47 +0000 (12:57 +0100)
We can steal the strings instead of creating more copies.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
src/vbox/vbox_common.c

index 8f5f04efb30f088e9383095bd5317fc6c6dd08d1..1a413e4acade614b6fe8180c21a4bd4b8a6a8810 100644 (file)
@@ -3719,9 +3719,7 @@ vboxDumpNetwork(vboxDriverPtr data, INetworkAdapter *adapter)
         gVBoxAPI.UINetworkAdapter.GetBridgedInterface(adapter, &utf16);
 
         VBOX_UTF16_TO_UTF8(utf16, &utf8);
-        ignore_value(VIR_STRDUP(net->data.bridge.brname, utf8));
-
-        VBOX_UTF8_FREE(utf8);
+        VIR_STEAL_PTR(net->data.bridge.brname, utf8);
         VBOX_UTF16_FREE(utf16);
         break;
 
@@ -3731,9 +3729,7 @@ vboxDumpNetwork(vboxDriverPtr data, INetworkAdapter *adapter)
         gVBoxAPI.UINetworkAdapter.GetInternalNetwork(adapter, &utf16);
 
         VBOX_UTF16_TO_UTF8(utf16, &utf8);
-        ignore_value(VIR_STRDUP(net->data.internal.name, utf8));
-
-        VBOX_UTF8_FREE(utf8);
+        VIR_STEAL_PTR(net->data.internal.name, utf8);
         VBOX_UTF16_FREE(utf16);
         break;
 
@@ -3743,9 +3739,7 @@ vboxDumpNetwork(vboxDriverPtr data, INetworkAdapter *adapter)
         gVBoxAPI.UINetworkAdapter.GetHostOnlyInterface(adapter, &utf16);
 
         VBOX_UTF16_TO_UTF8(utf16, &utf8);
-        ignore_value(VIR_STRDUP(net->data.network.name, utf8));
-
-        VBOX_UTF8_FREE(utf8);
+        VIR_STEAL_PTR(net->data.network.name, utf8);
         VBOX_UTF16_FREE(utf16);
         break;